1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
#![cfg_attr(not(feature = "std"), no_std)]

pub use pallet::*;

#[cfg(test)]
mod mock;

#[cfg(test)]
mod tests;

#[cfg(feature = "runtime-benchmarks")]
mod benchmarking;

mod functions;
pub mod types;

#[frame_support::pallet]
pub mod pallet {
  use frame_support::pallet_prelude::*;
  //#[cfg(feature = "std")]
  //use frame_support::serde::{Deserialize, Serialize};
  use crate::types::*;
  use frame_support::sp_io::hashing::blake2_256;
  use frame_support::{pallet_prelude::BoundedVec, traits::Get};
  use frame_system::{
    offchain::{AppCrypto, CreateSignedTransaction, SignedPayload, Signer},
    pallet_prelude::*,
  };
  use sp_runtime::sp_std::str;
  use sp_runtime::sp_std::vec::Vec;
  use sp_runtime::{
    offchain::{
      storage_lock::{BlockAndTime, StorageLock},
      Duration,
    },
    transaction_validity::{InvalidTransaction, TransactionValidity, ValidTransaction},
  };

  const STORAGE_VERSION: StorageVersion = StorageVersion::new(1);

  /*--- Genesis Structs Section ---*/

  #[pallet::genesis_config]
  pub struct GenesisConfig {
    pub bdk_services_url: Vec<u8>,
  }

  #[cfg(feature = "std")]
  impl Default for GenesisConfig {
    fn default() -> Self {
      Self { bdk_services_url: b"https://bdk.hashed.systems".encode() }
    }
  }

  #[pallet::genesis_build]
  impl<T: Config> GenesisBuild<T> for GenesisConfig {
    fn build(&self) {
      <BDKServicesURL<T>>::put(
        BoundedVec::<u8, ConstU32<32>>::try_from(self.bdk_services_url.clone()).unwrap_or_default(),
      );
    }
  }

  /// Configure the pallet by specifying the parameters and types on which it depends.
  #[pallet::config]
  pub trait Config: frame_system::Config + CreateSignedTransaction<Call<Self>> {
    /// The identifier type for an offchain worker.
    type AuthorityId: AppCrypto<Self::Public, Self::Signature>;
    /// Because this pallet emits events, it depends on the runtime's definition of an event.
    type RuntimeEvent: From<Event<Self>> + IsType<<Self as frame_system::Config>::RuntimeEvent>;
    type ChangeBDKOrigin: EnsureOrigin<Self::RuntimeOrigin>;
    /*--- PSBT params ---*/
    #[pallet::constant]
    type XPubLen: Get<u32>;
    #[pallet::constant]
    type PSBTMaxLen: Get<u32>;
    /*--- Vault params ---*/
    /// It counts both owned vaults and vaults where the user is a cosigner
    #[pallet::constant]
    type MaxVaultsPerUser: Get<u32>;
    #[pallet::constant]
    type MaxCosignersPerVault: Get<u32>;
    #[pallet::constant]
    type VaultDescriptionMaxLen: Get<u32>;
    #[pallet::constant]
    type OutputDescriptorMaxLen: Get<u32>;
    #[pallet::constant]
    type MaxProposalsPerVault: Get<u32>;
  }

  #[pallet::pallet]
  #[pallet::storage_version(STORAGE_VERSION)]
  #[pallet::generate_store(pub(super) trait Store)]
  pub struct Pallet<T>(_);

  #[pallet::event]
  #[pallet::generate_deposit(pub(super) fn deposit_event)]
  pub enum Event<T: Config> {
    /// Xpub and hash stored
    XPubStored([u8; 32], T::AccountId),
    /// Removed Xpub previously linked to the account
    XPubRemoved(T::AccountId),
    /// The PBST was succesfully inserted by an OCW
    PSBTStored([u8; 32]),
    /// The vault was succesfully inserted and linked to the account as owner
    VaultStored([u8; 32], T::AccountId),
    /// The vault was succesfully removed by its owner
    VaultRemoved([u8; 32], T::AccountId),
    /// An offchain worker inserted a vault's descriptor
    DescriptorsStored([u8; 32]),
    /// A proposal has been inserted.
    ProposalStored([u8; 32], T::AccountId),
    /// A proposal has been removed.
    ProposalRemoved([u8; 32], T::AccountId),
    /// The user has uploaded its own PSBT
    ProposalSigned([u8; 32], T::AccountId),
    /// A proposal has been set to be finalized
    ProposalFinalized([u8; 32], T::AccountId),
    /// A proposal tx has been inserted by an OCW
    ProposalTxIdStored([u8; 32]),
    /// A proof of reserve was stored for the vault
    ProofOfReserveStored([u8; 32]),
    /// A psbt was stored for the vaults Proof of reserve
    ProofPSBTStored([u8; 32]),
    /// All the cosigners signed the proof of reserve
    ProofFinalized([u8; 32]),
  }

  // Errors inform users that something went wrong.
  #[pallet::error]
  pub enum Error<T> {
    /// Work in progress!
    NotYetImplemented,
    /// Xpub shouldn't be empty
    NoneValue,
    // The xpub has already been uploaded and taken by an account
    XPubAlreadyTaken,
    /// The Account doesn't have an xpub
    XPubNotFound,
    /// The user already has an xpub, try to remove it first
    UserAlreadyHasXpub,
    /// The Xpub cant be removed/changed because a vault needs it
    XpubLinkedToVault,
    /// The generated Hashes aren't the same
    HashingError,
    /// Found Invalid name on an additional field
    InvalidAdditionalField,
    /// The vault threshold cannot be greater than the number of vault participants
    InvalidVaultThreshold,
    /// A defined cosigner reached its vault limit
    SignerVaultLimit,
    /// Too many cosigners
    ExceedMaxCosignersPerVault,
    /// Vault not found
    VaultNotFound,
    /// A vault needs at least 1 cosigner
    NotEnoughCosigners,
    /// Only the owner of this vault can do this transaction
    VaultOwnerPermissionsNeeded,
    /// Vault members cannot be duplicate
    DuplicateVaultMembers,
    /// The account must participate in the vault to make a proposal or sign
    SignerPermissionsNeeded,
    /// The vault has too many proposals
    ExceedMaxProposalsPerVault,
    /// Proposal not found (id)
    ProposalNotFound,
    /// The account must be the proposer to remove it
    ProposerPermissionsNeeded,
    /// An identical proposal exists in storage
    AlreadyProposed,
    /// The proposal was already signed by the user
    AlreadySigned,
    /// The proposal is already finalized or broadcasted
    PendingProposalRequired,
    /// The proposal/Proof of reserve signatures need to surpass the vault's threshold
    NotEnoughSignatures,
    /// The proposal has structural failures
    InvalidProposal,
    /// This vault cant take proposals due to structural failures
    InvalidVault,
    /// The proof of reserve was not found
    ProofNotFound,
    /// The proposal/proof of reserve was already previously broadcasted
    AlreadyBroadcasted,
  }

  /*--- Onchain storage section ---*/
  /// Stores hash-xpub pairs
  #[pallet::storage]
  #[pallet::getter(fn xpubs)]
  pub(super) type Xpubs<T: Config> = StorageMap<
    _,
    Identity,
    [u8; 32], //that's the blake 2 hash result
    BoundedVec<u8, T::XPubLen>,
    OptionQuery,
  >;

  /// Keeps track of what accounts own what xpub.
  #[pallet::storage]
  #[pallet::getter(fn xpubs_by_owner)]
  pub(super) type XpubsByOwner<T: Config> =
    StorageMap<_, Blake2_256, T::AccountId, [u8; 32], OptionQuery>;

  #[pallet::storage]
  #[pallet::getter(fn proposals)]
  pub(super) type Proposals<T: Config> = StorageMap<
    _,
    Identity,
    [u8; 32], //proposalid
    Proposal<T>,
    OptionQuery,
  >;

  #[pallet::storage]
  #[pallet::getter(fn proposals_by_vault)]
  pub(super) type ProposalsByVault<T: Config> = StorageMap<
    _,
    Identity,
    [u8; 32],                                      //vaultId
    BoundedVec<[u8; 32], T::MaxProposalsPerVault>, //proposalId
    ValueQuery,
  >;

  /// Stores vaults
  #[pallet::storage]
  #[pallet::getter(fn vaults)]
  pub(super) type Vaults<T: Config> = StorageMap<
    _,
    Identity,
    [u8; 32], //hash
    Vault<T>,
    OptionQuery,
  >;
  /// Keeps track of what accounts own what xpub.
  #[pallet::storage]
  #[pallet::getter(fn vaults_by_signer)]
  pub(super) type VaultsBySigner<T: Config> = StorageMap<
    _,
    Twox64Concat,
    T::AccountId,                              // signer
    BoundedVec<[u8; 32], T::MaxVaultsPerUser>, // vault ids
    ValueQuery,
  >;

  /// Stores vaults proof-of-reserve
  ///
  #[pallet::storage]
  #[pallet::getter(fn proof_of_reserve)]
  pub(super) type ProofOfReserves<T: Config> = StorageMap<
    _,
    Identity,
    [u8; 32], //vault_id
    ProofOfReserve<T>,
    OptionQuery,
  >;

  #[pallet::type_value]
  pub(super) fn DefaultURL() -> BoundedVec<u8, ConstU32<32>> {
    BoundedVec::<u8, ConstU32<32>>::try_from(b"https://bdk.hashed.systems".encode())
      .unwrap_or_default()
  }
  #[pallet::storage]
  //#[pallet::getter(fn dummy)]
  pub(super) type BDKServicesURL<T: Config> =
    StorageValue<_, BoundedVec<u8, ConstU32<32>>, ValueQuery, DefaultURL>;

  #[pallet::hooks]
  impl<T: Config> Hooks<BlockNumberFor<T>> for Pallet<T> {
    /// Offchain Worker entry point.
    ///
    /// By implementing `fn offchain_worker` you declare a new offchain worker.
    /// This function will be called when the node is fully synced and a new best block is
    /// successfully imported.
    /// Note that it's not guaranteed for offchain workers to run on EVERY block, there might
    /// be cases where some blocks are skipped, or for some the worker runs twice (re-orgs),
    /// so the code should be able to handle that.
    fn offchain_worker(_block_number: T::BlockNumber) {
      // check if the node has an account available, the offchain worker can't submit
      // transactions without it
      let signer = Signer::<T, T::AuthorityId>::any_account();
      if !signer.can_sign() {
        return;
      }

      // Check if this OCW can modify the vaults
      let mut lock = StorageLock::<BlockAndTime<Self>>::with_block_and_time_deadline(
        b"nbv::vault-storage-lock",
        LOCK_BLOCK_EXPIRATION,
        Duration::from_millis(LOCK_TIMEOUT_EXPIRATION),
      );
      if let Ok(_guard) = lock.try_lock() {
        // check for pending vaults to insert
        let pending_vaults = Self::get_pending_vaults();
        let pending_proposals = Self::get_pending_proposals();
        let proposals_to_finalize = Self::get_proposals_to_finalize();
        //let proposals_to_broadcast = Self::get_proposals_to_finalize();
        log::info!("Pending vaults {:?}", pending_vaults.len());
        // This validation needs to be done after the lock:
        if !pending_vaults.is_empty() {
          let generated_vaults = Self::gen_vaults_payload_by_bulk(pending_vaults);
          Self::send_ocw_insert_descriptors(generated_vaults, &signer);
        }
        if !pending_proposals.is_empty() {
          log::info!("Pending proposals {:?}", pending_proposals.len());
          let generated_proposals_payload = Self::gen_proposals_payload_by_bulk(
            pending_proposals,
            b"/gen_psbt".to_vec(),
            &Self::gen_proposal_json_body,
          );
          Self::send_ocw_insert_psbts(generated_proposals_payload, &signer);
        }
        if !proposals_to_finalize.is_empty() {
          // generate proposal payloads:
          let finalized_proposals = Self::get_proposals_to_finalize();
          //Send unsigned tx:
          let generated_finalized_tx = Self::gen_proposals_payload_by_bulk(
            finalized_proposals,
            b"/finalize_trx".to_vec(),
            &Self::gen_finalize_json_body,
          );

          Self::send_ocw_finalize_psbts(generated_finalized_tx, &signer);
        }
      } else {
        log::error!("This OCW couln't get the lock");
      };
    }
  }

  #[pallet::call]
  impl<T: Config> Pallet<T> {
    /// ## XPub insertion
    ///
    /// This extrinsic inserts a user-defined xpub
    /// as well as in the pallet storage.
    ///
    /// ### Parameters:
    /// - `xpub`: Extended public key, it can be sent with or without fingerprint/derivation path
    ///
    /// ### Considerations
    /// - The origin must be Signed and the sender must have sufficient funds free for the transaction fee.
    /// - This extrinsic cannot handle a xpub update (yet). if it needs to be updated, remove it first and insert
    /// a new one.
    #[pallet::call_index(1)]
    #[pallet::weight(Weight::from_ref_time(10_000) + T::DbWeight::get().writes(2))]
    pub fn set_xpub(origin: OriginFor<T>, xpub: BoundedVec<u8, T::XPubLen>) -> DispatchResult {
      // Check that the extrinsic was signed and get the signer.
      let who = ensure_signed(origin.clone())?;
      ensure!(xpub.len() > 0, Error::<T>::NoneValue);
      ensure!(!<XpubsByOwner<T>>::contains_key(who.clone()), Error::<T>::UserAlreadyHasXpub);
      let manual_hash = xpub.clone().using_encoded(blake2_256);
      // Assert if the input xpub is free to take (or if the user owns it)
      match Self::get_xpub_status(who.clone(), manual_hash.clone()) {
        XpubStatus::Owned => log::info!("Xpub owned, nothing to insert"),
        XpubStatus::Taken => Err(Error::<T>::XPubAlreadyTaken)?, //xpub taken: abort tx
        XpubStatus::Free => {
          // xpub free: erase unused xpub and insert on maps
          // if <XpubsByOwner<T>>::contains_key(who.clone()) {
          // 	Self::remove_xpub_from_pallet_storage(who.clone())?;
          // }
          <Xpubs<T>>::insert(manual_hash, xpub.clone());
          // Confirm the xpub was inserted
          let mut inserted_hash = <Xpubs<T>>::hashed_key_for(manual_hash);
          // the 2nd half of the inserted_hash is the real key hash.
          let partial_hash = inserted_hash.split_off(32);
          // The manually calculated hash should always be equal to the StorageMap hash
          ensure!(partial_hash.as_slice() == manual_hash, Error::<T>::HashingError);
          // If everything is ok, insert the xpub in the owner->hash map
          <XpubsByOwner<T>>::insert(who.clone(), manual_hash);
        },
      }
      // Emit a success event.
      Self::deposit_event(Event::XPubStored(manual_hash, who));

      // Return a successful DispatchResult
      Ok(())
    }

    /// ## Xpub removal
    ///
    /// Removes the linked xpub from the account which signs the transaction.
    /// The xpub will be removed from both the pallet storage and identity registration.
    ///
    /// This tx does not takes any parameters.
    ///
    #[pallet::call_index(2)]
    #[pallet::weight(Weight::from_ref_time(10_000) + T::DbWeight::get().writes(2))]
    pub fn remove_xpub(origin: OriginFor<T>) -> DispatchResult {
      let who = ensure_signed(origin.clone())?;
      // The xpub must exists
      ensure!(<XpubsByOwner<T>>::contains_key(who.clone()), Error::<T>::XPubNotFound);
      // The xpub must not be used on a vault
      let vaults: Vec<[u8; 32]> = <VaultsBySigner<T>>::get(who.clone())
        .iter()
        .filter(|id| match <Vaults<T>>::get(id) {
          Some(vault) => {
            let vault_members = vault.get_vault_members();
            vault_members.contains(&who.clone())
          },
          None => false,
        })
        .cloned()
        .collect::<Vec<_>>();
      ensure!(vaults.is_empty(), Error::<T>::XpubLinkedToVault);

      Self::do_remove_xpub(who.clone())
    }

    /// Vault insertion
    ///
    /// Inserts the vault on chain. Meant to be used by an offchain worker.
    ///
    /// ### Parameters:
    /// - `threshold`: The number of signatures needed for a proposal to be approved/finalized
    /// - `description`: A small definition. What will the vault be used for?
    /// - `include_owner_as_cosigner`: Add automatically the owner as cosigner
    /// - `cosigners`: The other accounts that will participate in vault proposals.
    ///
    /// ### Considerations
    /// - Do not include the vault owner on the `cosigners` list.
    ///
    #[pallet::call_index(3)]
    #[pallet::weight(Weight::from_ref_time(10_000) + T::DbWeight::get().writes(1))]
    pub fn create_vault(
      origin: OriginFor<T>,
      threshold: u32,
      description: BoundedVec<u8, T::VaultDescriptionMaxLen>,
      include_owner_as_cosigner: bool,
      mut cosigners: BoundedVec<T::AccountId, T::MaxCosignersPerVault>,
    ) -> DispatchResult {
      let who = ensure_signed(origin.clone())?;
      if include_owner_as_cosigner {
        cosigners
          .try_push(who.clone())
          .map_err(|_| Error::<T>::ExceedMaxCosignersPerVault)?;
      }
      //  Cosigners are already bounded, only is necessary to check if its not empty
      ensure!(cosigners.len() > 1, Error::<T>::NotEnoughCosigners);
      // Threshold needs to be greater than 0 and less than the current cosigners number
      ensure!(
        threshold > 0 && threshold <= (cosigners.len() as u32),
        Error::<T>::InvalidVaultThreshold
      );
      let vault = Vault::<T> {
        owner: who.clone(),
        threshold,
        description,
        cosigners,
        descriptors: Descriptors::<T::OutputDescriptorMaxLen> {
          output_descriptor: BoundedVec::<u8, T::OutputDescriptorMaxLen>::try_from(b"".to_vec())
            .expect("Error on encoding the descriptor to BoundedVec"),
          change_descriptor: None,
        },
        offchain_status: BDKStatus::default(),
      };

      Self::do_insert_vault(vault)
    }

    /// Vault removal
    ///
    /// Tries to remove vault and all its proposals, only the owner can call this extrinsic.
    ///
    /// ### Parameters:
    /// - `vault_id`: the vault to be removed with all its proposals
    ///
    /// ### Considerations:
    /// - Only the vault owner can perform this extrinsic
    ///
    #[pallet::call_index(4)]
    #[pallet::weight(Weight::from_ref_time(10_000) + T::DbWeight::get().writes(1))]
    pub fn remove_vault(origin: OriginFor<T>, vault_id: [u8; 32]) -> DispatchResult {
      let who = ensure_signed(origin.clone())?;

      Self::do_remove_vault(who, vault_id)
    }

    /// Vault transaction proposal
    ///
    /// Inserts a proposal on the specified vault.
    ///
    /// ### Parameters:
    /// - `vault_id`: the vault identifier in which the proposal will be inserted
    /// - `recipient_address`: Mainnet address to which the funds will be send
    /// - `amount_in_sats`: Amount to send in satoshis.
    /// - `description`: The reason for the proposal, why do you are proposing this?.
    ///
    /// ### Considerations
    /// - Please ensure the recipient address is a valid mainnet address.
    #[pallet::call_index(5)]
    #[pallet::weight(Weight::from_ref_time(10_000) + T::DbWeight::get().writes(1))]
    pub fn propose(
      origin: OriginFor<T>,
      vault_id: [u8; 32],
      recipient_address: BoundedVec<u8, T::XPubLen>,
      amount_in_sats: u64,
      description: BoundedVec<u8, T::VaultDescriptionMaxLen>,
    ) -> DispatchResult {
      let who = ensure_signed(origin.clone())?;
      // ensure user is in the vault
      let proposal = Proposal::<T> {
        proposer: who.clone(),
        vault_id,
        status: ProposalStatus::Pending,
        offchain_status: BDKStatus::default(),
        to_address: recipient_address,
        amount: amount_in_sats,
        fee_sat_per_vb: 1,
        description,
        tx_id: None,
        psbt: BoundedVec::<u8, T::PSBTMaxLen>::default(),
        signed_psbts: BoundedVec::<ProposalSignatures<T>, T::MaxCosignersPerVault>::default(),
      };
      Self::do_propose(proposal)
    }

    /// Proposal removal
    ///
    /// Tries to remove a specified proposal. Only the user who created the proposal can remove it.
    ///
    /// ### Parameters:
    /// - `proposal_id`: the proposal identifier
    ///
    #[pallet::call_index(6)]
    #[pallet::weight(Weight::from_ref_time(10_000) + T::DbWeight::get().writes(1))]
    pub fn remove_proposal(origin: OriginFor<T>, proposal_id: [u8; 32]) -> DispatchResult {
      let who = ensure_signed(origin.clone())?;
      let proposal = <Proposals<T>>::get(proposal_id).ok_or(Error::<T>::ProposalNotFound)?;
      // Only vault proposer can remove
      // validation before do_remove_proposal because the user is not needed anymore
      //TODO: proposal cannot be erased if readyToBroadcast() finalized or broadcasted
      // -> erase only pending
      ensure!(proposal.proposer.eq(&who), Error::<T>::ProposerPermissionsNeeded);
      Self::do_remove_proposal(proposal_id)
    }

    /// BDK URL insertion
    ///
    /// Changes the BDK-services endpoint, useful for pointing to the btc mainnet or testnet
    ///
    /// ### Parameters:
    /// - `new_url`: The new endpoint to which all the bdk related requests will be sent.
    ///
    /// ### Considerations
    /// - Ensure the new url is valid.
    /// - The url has a maximum length of 32 bytes
    #[pallet::call_index(7)]
    #[pallet::weight(Weight::from_ref_time(10_000) + T::DbWeight::get().writes(1))]
    pub fn set_bdk_url(
      origin: OriginFor<T>,
      new_url: BoundedVec<u8, ConstU32<32>>,
    ) -> DispatchResult {
      T::ChangeBDKOrigin::ensure_origin(origin.clone())?;
      <BDKServicesURL<T>>::put(new_url);
      Ok(())
    }

    /// PSBT signature insertion
    ///
    /// Stores the signature for a PSBT proposal
    ///
    ///
    /// ### Parameters:
    /// - `proposal_id`: the proposal identifier
    /// - `signature_payload`: a blob of psbt bytes, resulting from a external wallet
    ///
    /// ### Considerations
    /// - If successful, this process cannot be undone
    /// - A user can only sign a proposal once
    #[pallet::call_index(8)]
    #[pallet::weight(Weight::from_ref_time(10_000) + T::DbWeight::get().writes(1))]
    pub fn save_psbt(
      origin: OriginFor<T>,
      proposal_id: [u8; 32],
      signature_payload: BoundedVec<u8, T::PSBTMaxLen>,
    ) -> DispatchResult {
      let who = ensure_signed(origin.clone())?;
      Self::do_save_psbt(who, proposal_id, signature_payload)
    }

    /// Finalize PSBT
    ///
    /// Queries a proposal to be finalized generating a tx_id in the process, it can also be broadcasted if specified.
    ///
    /// ### Parameters:
    /// - `proposal_id`: the proposal identifier
    /// - `broadcast`: A boolean flag
    ///
    /// ### Considerations
    /// - If successful, this process cannot be undone
    /// - The proposal must have a valid PSBT
    /// - Any vault member can perform this extrinsic
    #[pallet::call_index(9)]
    #[pallet::weight(Weight::from_ref_time(10_000) + T::DbWeight::get().writes(1))]
    pub fn finalize_psbt(
      origin: OriginFor<T>,
      proposal_id: [u8; 32],
      broadcast: bool,
    ) -> DispatchResult {
      let who = ensure_signed(origin.clone())?;
      Self::do_finalize_psbt(who, proposal_id, broadcast)
    }

    /// Broadcast PSBT
    ///
    /// Queries a proposal to be broadcasted in case it wasn't on the finalization step.
    ///
    /// ### Parameters:
    /// - `proposal_id`: the vault identifier in which the proposal will be inserted
    ///
    /// ### Considerations
    /// - If successful, this process cannot be undone
    /// - The proposal must be finalized already
    /// - Any vault member can perform this extrinsic
    #[pallet::call_index(10)]
    #[pallet::weight(Weight::from_ref_time(10_000) + T::DbWeight::get().writes(1))]
    pub fn broadcast_psbt(origin: OriginFor<T>, proposal_id: [u8; 32]) -> DispatchResult {
      let who = ensure_signed(origin.clone())?;
      Self::do_finalize_psbt(who, proposal_id, true)
    }

    /// Create Proof of Reserve
    ///
    /// Stores a PoR for a defined vault.
    ///
    /// ### Parameters:
    /// - `vault_id`: the vault identifier in which the proof will be inserted
    /// - `message`: the message to be taken into account to generate the PoR PSBT
    /// - `psbt`: the psbt generated from bdk
    ///
    /// ### Considerations:
    /// - Any vault member can perform this extrinsic
    /// - A vault can only have a PoR at a time.
    #[pallet::call_index(11)]
    #[pallet::weight(Weight::from_ref_time(10_000) + T::DbWeight::get().writes(1))]
    pub fn create_proof(
      origin: OriginFor<T>,
      vault_id: [u8; 32],
      message: Description<T>,
      psbt: PSBT<T>,
    ) -> DispatchResult {
      let who = ensure_signed(origin.clone())?;
      Self::do_create_proof(who, vault_id, message, psbt)
    }

    /// Save Proof of reserve PSBT
    ///
    /// Updates the PoR with a new PSBT
    ///
    /// ### Parameters
    /// - `vault_id`: the vault identifier in which the proof is
    /// - `psbt`: the new psbt to insert, the signer will be linked to it.
    ///
    /// ### Considerations:
    /// - Any vault member can perform this extrinsic
    /// - A vault signer can only sabe its PSBT once.
    #[pallet::call_index(12)]
    #[pallet::weight(Weight::from_ref_time(10_000) + T::DbWeight::get().writes(1))]
    pub fn save_proof_psbt(
      origin: OriginFor<T>,
      vault_id: [u8; 32],
      psbt: PSBT<T>,
    ) -> DispatchResult {
      let who = ensure_signed(origin.clone())?;
      Self::do_save_proof_psbt(who, vault_id, psbt)
    }

    /// Finalize proof of reserve
    ///
    /// Updates the PoR with the final PSBT
    ///
    /// ### Parameters
    /// - `vault_id`: the vault identifier in which the proof is
    /// - `psbt`: the new psbt to insert, the signer will be linked to it.
    ///
    /// ### Considerations:
    /// - Any vault member can perform this extrinsic
    /// - A vault signer can only sabe its PSBT once.
    #[pallet::call_index(13)]
    #[pallet::weight(Weight::from_ref_time(10_000) + T::DbWeight::get().writes(1))]
    pub fn finalize_proof(
      origin: OriginFor<T>,
      vault_id: [u8; 32],
      psbt: PSBT<T>,
    ) -> DispatchResult {
      let who = ensure_signed(origin.clone())?;
      Self::do_finalize_proof(who, vault_id, psbt)
    }

    /// Kill almost all storage
    ///
    /// Use with caution!
    ///
    /// Can only be called by root and removes All vaults and proposals
    #[pallet::call_index(14)]
    #[pallet::weight(Weight::from_ref_time(10_000) + T::DbWeight::get().writes(1))]
    pub fn kill_storage(origin: OriginFor<T>) -> DispatchResult {
      T::ChangeBDKOrigin::ensure_origin(origin.clone())?;
      let _ = <Xpubs<T>>::clear(1000, None);
      let _ = <XpubsByOwner<T>>::clear(1000, None);
      let _ = <Proposals<T>>::clear(1000, None);
      let _ = <ProposalsByVault<T>>::clear(1000, None);
      let _ = <Vaults<T>>::clear(1000, None);
      let _ = <VaultsBySigner<T>>::clear(1000, None);
      let _ = <ProofOfReserves<T>>::clear(1000, None);
      Ok(())
    }

    /// Extrinsic to insert a valid vault descriptor
    ///
    /// Meant to be unsigned with signed payload and used by an offchain worker
    ///
    #[pallet::call_index(15)]
    #[pallet::weight(0)]
    pub fn ocw_insert_descriptors(
      origin: OriginFor<T>,
      payload: VaultsPayload<T::Public>,
      _signature: T::Signature,
    ) -> DispatchResult {
      // This ensures that the function can only be called via unsigned transaction.
      ensure_none(origin.clone())?;
      payload
        .vaults_payload
        .iter()
        .find_map(|vault_payload| {
          let output_descriptor = BoundedVec::<u8, T::OutputDescriptorMaxLen>::try_from(
            vault_payload.output_descriptor.clone(),
          )
          .expect("Error trying to convert desc to bounded vec");
          let change_descriptor = BoundedVec::<u8, T::OutputDescriptorMaxLen>::try_from(
            vault_payload.change_descriptor.clone(),
          )
          .expect("Error trying to convert change desc to bounded vec");
          let descriptors = Descriptors::<T::OutputDescriptorMaxLen> {
            output_descriptor,
            change_descriptor: Some(change_descriptor),
          };
          let status: BDKStatus<T::VaultDescriptionMaxLen> = vault_payload.clone().status.into();
          //assert!(Self::do_insert_descriptors(vault_payload.vault_id,descriptors).is_ok());
          let tx_res = Self::do_insert_descriptors(vault_payload.vault_id, descriptors, status);
          if tx_res.is_err() {
            return Some(tx_res);
          }
          None
        })
        .unwrap_or(Ok(()))
    }

    /// Extrinsic to insert a valid proposal PSBT
    ///
    /// Meant to be unsigned with signed payload and used by an offchain worker
    ///
    #[pallet::call_index(16)]
    #[pallet::weight(0)]
    pub fn ocw_insert_psbts(
      origin: OriginFor<T>,
      payload: ProposalsPayload<T::Public>,
      _signature: T::Signature,
    ) -> DispatchResult {
      ensure_none(origin.clone())?;
      payload
        .proposals_payload
        .iter()
        .find_map(|proposal_psbt| {
          let bounded_psbt = BoundedVec::<u8, T::PSBTMaxLen>::try_from(proposal_psbt.psbt.clone())
            .expect("Error trying to bound the psbt");
          let status: BDKStatus<T::VaultDescriptionMaxLen> = proposal_psbt.status.clone().into();
          let tx_res = Self::do_insert_psbt(proposal_psbt.proposal_id, bounded_psbt, status);
          if tx_res.is_err() {
            return Some(tx_res);
          }
          None
        })
        .unwrap_or(Ok(()))?;
      Ok(())
    }

    /// Extrinsic to insert a valid proposal TX_ID
    ///
    /// Meant to be unsigned with signed payload and used by an offchain worker
    ///
    #[pallet::call_index(17)]
    #[pallet::weight(0)]
    pub fn ocw_finalize_psbts(
      origin: OriginFor<T>,
      payload: ProposalsPayload<T::Public>, // here the payload
      _signature: T::Signature, // we don't need to verify the signature here because it has been verified in
                                //   `validate_unsigned` function when sending out the unsigned tx.
    ) -> DispatchResult {
      ensure_none(origin.clone())?;
      log::info!("Extrinsic recibido payload de: {:?}", payload);
      payload.proposals_payload.iter().try_for_each(|proposal_tx| {
        let bounded_tx_id =
          BoundedVec::<u8, T::VaultDescriptionMaxLen>::try_from(proposal_tx.psbt.clone());
        let status: BDKStatus<T::VaultDescriptionMaxLen> = proposal_tx.status.clone().into();
        Self::do_insert_tx_id(proposal_tx.proposal_id, bounded_tx_id.ok(), status)
      })?;
      Ok(())
    }
  }

  #[pallet::validate_unsigned]
  impl<T: Config> ValidateUnsigned for Pallet<T> {
    type Call = Call<T>;

    fn validate_unsigned(_source: TransactionSource, call: &Self::Call) -> TransactionValidity {
      let valid_tx = |provide| {
        ValidTransaction::with_tag_prefix("bdks")
          .priority(UNSIGNED_TXS_PRIORITY)
          .and_provides([&provide])
          .longevity(3)
          .propagate(true)
          .build()
      };

      match call {
        Call::ocw_insert_descriptors { ref payload, ref signature } => {
          if !SignedPayload::<T>::verify::<T::AuthorityId>(payload, signature.clone()) {
            return InvalidTransaction::BadProof.into();
          }
          valid_tx(b"unsigned_extrinsic_with_signed_payload".to_vec())
        }, // compiler complains if they aren't on different match arms
        Call::ocw_insert_psbts { ref payload, ref signature } => {
          if !SignedPayload::<T>::verify::<T::AuthorityId>(payload, signature.clone()) {
            return InvalidTransaction::BadProof.into();
          }
          valid_tx(b"unsigned_extrinsic_with_signed_payload".to_vec())
        },
        Call::ocw_finalize_psbts { ref payload, ref signature } => {
          if !SignedPayload::<T>::verify::<T::AuthorityId>(payload, signature.clone()) {
            return InvalidTransaction::BadProof.into();
          }
          valid_tx(b"unsigned_extrinsic_with_signed_payload".to_vec())
        },
        _ => InvalidTransaction::Call.into(),
      }
    }
  }
}